This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Improves documentation on num_slashing_spans
when calling withdraw_unbounded
in Staking.
#14185
Merged
paritytech-processbot
merged 3 commits into
master
from
gpestana/11714-num_slashing_spans_docs
May 27, 2023
Merged
Improves documentation on num_slashing_spans
when calling withdraw_unbounded
in Staking.
#14185
paritytech-processbot
merged 3 commits into
master
from
gpestana/11714-num_slashing_spans_docs
May 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpestana
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
T1-runtime
This PR/Issue is related to the topic “runtime”.
labels
May 21, 2023
Ank4n
approved these changes
May 21, 2023
kianenigma
reviewed
May 22, 2023
kianenigma
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few other calls ins taking require num_slashing_spans
. Rather write it in one place, and reference it multiple times?
Approving speculatively to unblock you in the future.
Co-authored-by: Kian Paimani <[email protected]>
bot merge |
Waiting for commit status. |
paritytech-processbot
bot
deleted the
gpestana/11714-num_slashing_spans_docs
branch
May 27, 2023 14:46
Ank4n
pushed a commit
that referenced
this pull request
Jul 8, 2023
…_unbounded` in Staking. (#14185) * gpestana/11714-num_slashing_spans_docs * Update frame/staking/src/pallet/mod.rs Co-authored-by: Kian Paimani <[email protected]> * All calls that take num_slashing_span as parameters refer to comments on it --------- Co-authored-by: Kian Paimani <[email protected]>
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…_unbounded` in Staking. (paritytech#14185) * gpestana/11714-num_slashing_spans_docs * Update frame/staking/src/pallet/mod.rs Co-authored-by: Kian Paimani <[email protected]> * All calls that take num_slashing_span as parameters refer to comments on it --------- Co-authored-by: Kian Paimani <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
T1-runtime
This PR/Issue is related to the topic “runtime”.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more information about the
num_slashing_spans
parameter of the callwithdraw_unbonded
in the Staking pallet.Closes #11714