Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Improves documentation on num_slashing_spans when calling withdraw_unbounded in Staking. #14185

Merged
merged 3 commits into from
May 27, 2023

Conversation

gpestana
Copy link
Contributor

Adds more information about the num_slashing_spans parameter of the call withdraw_unbonded in the Staking pallet.

Closes #11714

@gpestana gpestana added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”. labels May 21, 2023
@gpestana gpestana self-assigned this May 21, 2023
@gpestana gpestana requested review from a team, Ank4n and kianenigma May 21, 2023 22:30
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few other calls ins taking require num_slashing_spans. Rather write it in one place, and reference it multiple times?

Approving speculatively to unblock you in the future.

@gpestana gpestana requested a review from a team May 27, 2023 13:59
@gpestana
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 10f06f4 into master May 27, 2023
@paritytech-processbot paritytech-processbot bot deleted the gpestana/11714-num_slashing_spans_docs branch May 27, 2023 14:46
Ank4n pushed a commit that referenced this pull request Jul 8, 2023
…_unbounded` in Staking. (#14185)

* gpestana/11714-num_slashing_spans_docs

* Update frame/staking/src/pallet/mod.rs

Co-authored-by: Kian Paimani <[email protected]>

* All calls that take num_slashing_span as parameters refer to comments on it

---------

Co-authored-by: Kian Paimani <[email protected]>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
…_unbounded` in Staking. (paritytech#14185)

* gpestana/11714-num_slashing_spans_docs

* Update frame/staking/src/pallet/mod.rs

Co-authored-by: Kian Paimani <[email protected]>

* All calls that take num_slashing_span as parameters refer to comments on it

---------

Co-authored-by: Kian Paimani <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a note with more info about num_slashing_spans for the call withdraw_unbonded in the Staking pallet.
3 participants