This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Change unit test upload step #14124
Merged
Change unit test upload step #14124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvicsam
approved these changes
May 11, 2023
altaua
approved these changes
May 11, 2023
|
If you want to keep the separate upload job, can't you collect artifacts by explicitly referencing the parallel jobs as |
Sure. I see one major drawback: you have either hardcode number of parallel jobs and job names or make something fancy to automate it in case the number of parallel jobs will be changed in the future(very likely). Also this will add the complexity to artifacts name and hence tracking them in the Elasticsearch. Anyway i didn't find this very attractive) The second best is to merge 3 files in the upload step. Don't like it either) |
mateo-moon
added
the
B0-silent
mateo-moon
force-pushed
the
oleg/ci-cd/flaky_upload_fix
branch
from
c471591
to
66c9c55
Compare
mateo-moon
force-pushed
the
oleg/ci-cd/flaky_upload_fix
branch
from
66c9c55
to
2003eb8
Compare
|
bot rebase |
|
Rebased |
gpestana
pushed a commit
that referenced
this pull request
May 27, 2023
Co-authored-by: parity-processbot <>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first design with separate step for tests upload there was fundamental bug - gitlab doesn't merge artifacts from parallel jobs) Why would it!? Although, i think the dedicates step is more clean solution i find adding the complexity and add additional step with merging artifact from parallel jobs very error prone and excessive. So combining this 2 steps maybe not elegant solution but most optimal.