Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix(in_mem): fix the clone logic #14038

Merged
merged 1 commit into from
Apr 29, 2023
Merged

fix(in_mem): fix the clone logic #14038

merged 1 commit into from
Apr 29, 2023

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Apr 28, 2023 •
edited
Loading

The clone logic is wrong. Should clone Arc rather than clone inner BlockchainStorage

cheme
cheme approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

From what I read (substrate only), this clone is not really use, but seems important to fix it (can be a footgun).

@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Apr 29, 2023
@bkchr bkchr merged commit 74b2c92 into paritytech:master Apr 29, 2023
gpestana pushed a commit that referenced this pull request May 4, 2023
@yjhmelody @gpestana
fix(in_mem): fix the clone logic (#14038)
9ad2b40
@yjhmelody yjhmelody deleted the fix-in-mem-blockchain branch May 25, 2023 15:24
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@yjhmelody @nathanwhit
fix(in_mem): fix the clone logic (paritytech#14038)
9d3eba6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cheme cheme cheme approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yjhmelody @cheme @bkchr