Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Improve try-state docs #13967

Merged
merged 6 commits into from
May 21, 2023
Merged

Improve try-state docs #13967

merged 6 commits into from
May 21, 2023

Conversation

Szegoo
Copy link
Contributor

@Szegoo Szegoo commented Apr 20, 2023

Part of: #13796

@Szegoo Szegoo marked this pull request as ready for review April 20, 2023 20:15
@Szegoo
Copy link
Contributor Author

Szegoo commented Apr 20, 2023

@liamaharon PTAL.

liamaharon
liamaharon approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Did you check there were no similar issues with the other documented commands?

utils/frame/try-runtime/cli/src/lib.rs Outdated Show resolved Hide resolved
@liamaharon liamaharon added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 21, 2023
@Szegoo
Copy link
Contributor Author

Szegoo commented Apr 21, 2023

Did you check there were no similar issues with the other documented commands?

Yeah made some fixes. I have run all the commands locally, it should be good now.

@liamaharon liamaharon mentioned this pull request Apr 21, 2023
Closed
6 tasks
@liamaharon liamaharon requested a review from a team May 21, 2023 16:03
@bkchr bkchr merged commit e85188b into paritytech:master May 21, 2023
gpestana pushed a commit that referenced this pull request May 27, 2023
@Szegoo @gpestana
Improve try-state docs (#13967)
3c5079f 
* Improve Try-State docs

* fmt

* fixes
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@Szegoo @nathanwhit
Improve try-state docs (paritytech#13967)
679ebc0 
* Improve Try-State docs

* fmt

* fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liamaharon liamaharon liamaharon approved these changes

@bkchr bkchr bkchr approved these changes

@kianenigma kianenigma Awaiting requested review from kianenigma

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Szegoo @bkchr @liamaharon