-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Try-state for Referenda pallet #13949
Try-state for Referenda pallet #13949
Conversation
@ggwpez Could you take a quick look? |
frame/referenda/src/lib.rs
Outdated
/// * The submission deposit cannot be less than `T::SubmissionDeposit`. | ||
/// | ||
/// Looking at tracks: | ||
/// * The `TrackQueue` should be empty if `DecidingCount` is less than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is possible when something is removed from the decision stage, and only with the next block the task from the queue will be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, this comment should probably be updated:
substrate/frame/referenda/src/lib.rs
Lines 238 to 240 in 6f0f5a9
/// This should be empty if `DecidingCount` is less than `TrackInfo::max_deciding`. | |
#[pallet::storage] | |
pub type TrackQueue<T: Config<I>, I: 'static = ()> = StorageMap< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If in doubt, please remove it form the PR so this can be moved forward.
Co-authored-by: Muharem Ismailov <[email protected]>
@muharem Thanks for your review, I am moving this into draft now, I want to give this some more thought to see if there are some other things that should be added/removed. |
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
can you please rebase? |
Co-authored-by: Liam Aharon <[email protected]>
bot fmt |
@gpestana https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3288286 was started for your command Comment |
@gpestana Command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment but lgtm, thanks for the PR!
bot merge |
/tip medium |
@liamaharon You are not allowed to request a tip. Only members of paritytech/tip-bot-approvers are allowed. |
@juangirini could you please tip? |
@Szegoo could you please add your dot/ksm address to the PR description for a tip |
@juangirini Recent release of the tip bot can now @Szegoo Has the address in the bio so we can try that. |
@rzadp that's awesome, thanks for the update |
/tip medium |
@juangirini A medium (80 DOT) tip was successfully submitted for @Szegoo (126X27SbhrV19mBFawys3ovkyBS87SGfYwtwa8J2FjHrtbmA on polkadot). https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/referenda |
Part of: paritytech/polkadot-sdk#239