This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
wasm-builder: Always build runtime with the toolchain used for the outer build
#13579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
added
A0-please_review
4 tasks
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
This pr makes it work without breaking changes: #13580 |
bkchr
reviewed
Mar 10, 2023
Comment on lines
-146
to
-147
| /// Environment variable to set the toolchain used to compile the wasm binary. | ||
| const WASM_BUILD_TOOLCHAIN: &str = "WASM_BUILD_TOOLCHAIN"; |
There was a problem hiding this comment.
This clearly removes stuff that shouldn't be removed.
There was a problem hiding this comment.
Yeah I thought we don't need the override anymore and saw the chance for some simplification. But it might be necessary for the transition at least.
Nice :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recently released version 1.68 of Rust we no longer need a nightly compiler in order to compile the runtime. The last feature we were missing is the ability to set a oom handler. With the new Rust version a default handler is supplied which just panics. Overriding this handler is still unstable. Hence in order to make this work we need to remove our custom handler.
The consensus is that removing the custom handler is a good tradeoff for getting a runtime compiled with the stable toolchain.
This PR does the following:
wasm-builderto always use the toolchain for the runtime build that it is being compiled with itselfwasm-buildermanifest so we fail early if an old Rust version is usedNote
The CI on this PR will fail until the Rust version in the CI image is updated.