Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Nfts: Make ItemConfig members public #13575

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Nfts: Make ItemConfig members public #13575

merged 1 commit into from
Mar 10, 2023

Conversation

jasl
Copy link
Contributor

@jasl jasl commented Mar 9, 2023

This would allow construct ItemConfig directly, e.g.

let config = ItemConfig {
  settings: ItemSettings::from_disabled(ItemSetting::Transferable | ItemSetting::UnlockedMetadata),
}

Opinions:

  • ItemConfig default is ambiguous, you don't know by default ItemSettings is all enabled or disabled
  • Maybe mint_into should allow optional item_config, when None it will use collection's default_item_settings

@jasl jasl changed the title Nfts: Make ItemConfig members pub Nfts: Make ItemConfig members public Mar 9, 2023
@jsidorenko jsidorenko added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 10, 2023
@jsidorenko
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 8d10997

@jsidorenko
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 0f3b2a2 into paritytech:master Mar 10, 2023
@jasl jasl deleted the pub-nft-item-config-members branch March 10, 2023 09:24
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
@jasl @ukint-vs
Nfts: Make ItemConfig members pub (paritytech#13575)
68466b0
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@jasl @nathanwhit
Nfts: Make ItemConfig members pub (paritytech#13575)
7dd18f0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsidorenko jsidorenko jsidorenko approved these changes

@KiChjang KiChjang KiChjang approved these changes

@gilescope gilescope gilescope approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasl @jsidorenko @gilescope @KiChjang