Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Expose ChargedAmount #13488

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Expose ChargedAmount #13488

merged 2 commits into from
Mar 1, 2023

Conversation

pmikolajczyk41
Copy link
Contributor

@pmikolajczyk41 pmikolajczyk41 commented Feb 28, 2023 •
edited
Loading

Exposing ChargedAmount type through chain_extension module. It shouldn't do anything harmful, since we still cannot construct it ourselves, guaranteeing that it was constructed by runtime internals.

Examples of usage:

  1. https://github.com/727-Ventures/obce/blob/liminal-v0.9.32/src/substrate/mod.rs#L190

OBCE generates glue code that automatically constructs ExtensionContext, with ChargedAmount passed to it when weight pre-charging is enabled. To actually refer to the ChargedAmount type, we need it exposed.

  1. https://github.com/Cardinal-Cryptography/aleph-node/blob/91d084ef04b82af1efa8c3a566fb4f7fe118ddab/bin/runtime/src/chain_extension/environment.rs#L19

For testing chain extension it is sometimes useful to mock charging. However, in order to abstract it, we also have to know appropriate type for real environment.

@athei athei added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. labels Feb 28, 2023
@athei athei requested a review from agryaznov February 28, 2023 10:26
@athei
Copy link
Member

athei commented Feb 28, 2023

Can you elaborate in your PR description why this change is useful? This is interesting for posterity.

@pmikolajczyk41
Copy link
Contributor Author

@athei I added two usecases

@athei athei merged commit 376ada8 into paritytech:master Mar 1, 2023
gpestana pushed a commit that referenced this pull request Mar 1, 2023
@pmikolajczyk41 @gpestana
Expose ChargedAmount (#13488)
1349e6a 
* Expose `ChargedAmount`

* Fix imports
pmikolajczyk41 added a commit to pmikolajczyk41/substrate that referenced this pull request Mar 2, 2023
@pmikolajczyk41
Expose ChargedAmount (paritytech#13488)
bc2352b 
* Expose `ChargedAmount`

* Fix imports

(cherry picked from commit 376ada8)
@pmikolajczyk41 pmikolajczyk41 mentioned this pull request Mar 2, 2023
Merged
pmikolajczyk41 added a commit to Cardinal-Cryptography/substrate that referenced this pull request Mar 2, 2023
@pmikolajczyk41
Expose ChargedAmount (paritytech#13488) (#37)
0d25bff 
* Expose `ChargedAmount`

(cherry picked from commit 376ada8)
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
@librelois librelois mentioned this pull request Apr 6, 2023
Closed
ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
@pmikolajczyk41 @ukint-vs
Expose ChargedAmount (paritytech#13488)
e9ca204 
* Expose `ChargedAmount`

* Fix imports
kostekIV pushed a commit to Cardinal-Cryptography/substrate that referenced this pull request May 16, 2023
@pmikolajczyk41 @kostekIV
Expose ChargedAmount (paritytech#13488) (#37)
1a6719b 
* Expose `ChargedAmount`

(cherry picked from commit 376ada8)
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@pmikolajczyk41 @nathanwhit
Expose ChargedAmount (paritytech#13488)
720d953 
* Expose `ChargedAmount`

* Fix imports
paritytech-processbot bot pushed a commit that referenced this pull request Aug 10, 2023
@gpestana @ggwpez
@davxy @yjhmelody @bkchr @koute @dmitry-markin @lazam @andresilva @pmikolajczyk41 @acatangiu @kianenigma
[NPoS] Implements dynamic number of nominators (#12970)
57d2e53 
* Implements dynamic nominations per nominator

* Adds SnapshotBounds and ElectionSizeTracker

* Changes the ElectionDataProvider interface to receive ElectionBounds as input

* Implements get_npos_voters with ElectionBounds

* Implements get_npos_targets with ElectionBounds

* Adds comments

* tests

* Truncates nomninations that exceed nominations quota; Old tests passing

* Uses DataProviderBounds and ElectionBounds (to continue)

* Finishes conversions - tests passing

* Refactor staking in babe mocks

* Replaces MaxElectableTargets and MaxElectingVoters with ElectionBounds; Adds more tests

* Fixes nits; node compiling

* bechmarks

* removes nomination_quota extrinsic to request the nomination quota

* Lazy quota check, ie. at nominate time only

* remove non-working test (for now)

* tests lazy nominations quota when quota is lower than current number of nominated targets

* Adds runtime API and custom RPC call for clients to query the nominations quota for a given balance

* removes old rpc

* Cosmetic touches

* All mocks working

* Fixes benchmarking mocks

* nits

* more tests

* renames trait methods

* nit

* ".git/.scripts/commands/fmt/fmt.sh"

* Fix V2 PoV benchmarking (#13485)

* Bump default 'additional_trie_layers' to two

The default here only works for extremely small runtimes, which have
no more than 16 storage prefices. This is changed to a "sane" default
of 2, which is save for runtimes with up to 4096 storage prefices (eg StorageValue).

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Update tests and test weights

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* Fix PoV weights

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_message_queue

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton

* Fix sanity check

>0 would also do as a check, but let's try this.

Signed-off-by: Oliver Tale-Yazdi <[email protected]>

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>

* Move BEEFY code to consensus (#13484)

* Move beefy primitives to consensus dir
* Move beefy gadget to client consensus folder
* Rename beefy crates

* chore: move genesis block builder to chain-spec crate. (#13427)

* chore: move genesis block builder to block builder crate.

* add missing file

* chore: move genesis block builder to sc-chain-spec

* Update client/chain-spec/src/genesis.rs

Co-authored-by: Bastian Köcher <[email protected]>

* Update test-utils/runtime/src/genesismap.rs

Co-authored-by: Bastian Köcher <[email protected]>

* Update test-utils/runtime/client/src/lib.rs

* fix warnings

* fix warnings

---------

Co-authored-by: Bastian Köcher <[email protected]>

* Speed up storage iteration from within the runtime (#13479)

* Speed up storage iteration from within the runtime

* Move the cached iterator into an `Option`

* Use `RefCell` in no_std

* Simplify the code slightly

* Use `Option::replace`

* Update doc comment for `next_storage_key_slow`

* Make unbounded channels size warning exact (part 1) (#13490)

* Replace `futures-channel` with `async-channel` in `out_events`

* Apply suggestions from code review

Co-authored-by: Koute <[email protected]>

* Also print the backtrace of `send()` call

* Switch from `backtrace` crate to `std::backtrace`

* Remove outdated `backtrace` dependency

* Remove `backtrace` from `Cargo.lock`

---------

Co-authored-by: Koute <[email protected]>

* Removal of Prometheus alerting rules deployment in cloud-infra (#13499)

* sp-consensus: remove unused error variants (#13495)

* Expose `ChargedAmount` (#13488)

* Expose `ChargedAmount`

* Fix imports

* sc-consensus-beefy: fix metrics: use correct names (#13494)


Signed-off-by: acatangiu <[email protected]>

* clippy fix

* removes NominationsQuotaExceeded event

* Update frame/staking/src/lib.rs

Co-authored-by: Ross Bulat <[email protected]>

* adds back the npos_max_iter

* remove duplicate imports added after merge

* fmt

* Adds comment in public struct; Refactors CountBound and SizeCount to struct

* addresses various pr comments

* PR comment reviews

* Fixes on-chain election bounds and related code

* EPM checks the size of the voter list returned by the data provider

* cosmetic changes

* updates e2e tests mock

* Adds more tests for size tracker and refactors code

* Adds back only_iterates_max_2_times_max_allowed_len test

* Refactor

* removes unecessary dependency

* empty commit -- restart all stuck CI jobs

* restarts ci jobs

* Renames ElectionBounds -> Bounds in benchmarking mocks et al

* updates mocks

* Update frame/election-provider-support/src/lib.rs

Co-authored-by: Kian Paimani <[email protected]>

* Update frame/staking/src/pallet/impls.rs

Co-authored-by: Kian Paimani <[email protected]>

* Update frame/election-provider-support/src/lib.rs

Co-authored-by: Kian Paimani <[email protected]>

* Update frame/staking/src/tests.rs

Co-authored-by: Kian Paimani <[email protected]>

* more checks in api_nominations_quota in tests

* Improves docs

* fixes e2e tests

* Uses size_hint rather than mem::size_of in size tracker; Refactor size tracker to own module

* nits from reviews

* Refactors bounds to own module; improves docs

* More tests and docs

* fixes docs

* Fixes benchmarks

* Fixes rust docs

* fixes bags-list remote-ext-tests

* Simplify bound checks in create_snapshot_external

* Adds target size check in get_npos_targets

* ".git/.scripts/commands/fmt/fmt.sh"

* restart ci

* rust doc fixes and cosmetic nits

* rollback upgrade on parity-scale-codec version (unecessary)

* reset cargo lock, no need to update it

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: acatangiu <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Davide Galassi <[email protected]>
Co-authored-by: yjh <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Koute <[email protected]>
Co-authored-by: Dmitry Markin <[email protected]>
Co-authored-by: Anthony Lazam <[email protected]>
Co-authored-by: André Silva <[email protected]>
Co-authored-by: Piotr Mikołajczyk <[email protected]>
Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: Ross Bulat <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SkymanOne SkymanOne SkymanOne approved these changes

@athei athei athei approved these changes

@agryaznov agryaznov Awaiting requested review from agryaznov

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Smart Contracts
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmikolajczyk41 @athei @SkymanOne