Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

pallet-assets: Rename total_supply to amount #13229

Merged
merged 4 commits into from
Jan 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frame/assets/src/benchmarking.rs
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ benchmarks_instance_pallet! {
let amount = T::Balance::from(100u32);
}: _(SystemOrigin::Signed(caller.clone()), asset_id, caller_lookup, amount)
verify {
assert_last_event::<T, I>(Event::Issued { asset_id: asset_id.into(), owner: caller, total_supply: amount }.into());
assert_last_event::<T, I>(Event::Issued { asset_id: asset_id.into(), owner: caller, amount }.into());
}

burn {
Expand Down
15 changes: 6 additions & 9 deletions frame/assets/src/functions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -354,18 +354,15 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> {
if let Some(check_issuer) = maybe_check_issuer {
ensure!(check_issuer == details.issuer, Error::<T, I>::NoPermission);
}
debug_assert!(
T::Balance::max_value() - details.supply >= amount,
"checked in prep; qed"
);
debug_assert!(details.supply.checked_add(&amount).is_some(), "checked in prep; qed");

details.supply = details.supply.saturating_add(amount);

Ok(())
})?;
Self::deposit_event(Event::Issued {
asset_id: id,
owner: beneficiary.clone(),
total_supply: amount,
});

Self::deposit_event(Event::Issued { asset_id: id, owner: beneficiary.clone(), amount });

Ok(())
}

Expand Down
8 changes: 3 additions & 5 deletions frame/assets/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,7 @@ pub use types::*;

use scale_info::TypeInfo;
use sp_runtime::{
traits::{
AtLeast32BitUnsigned, Bounded, CheckedAdd, CheckedSub, Saturating, StaticLookup, Zero,
},
traits::{AtLeast32BitUnsigned, CheckedAdd, CheckedSub, Saturating, StaticLookup, Zero},
ArithmeticError, TokenError,
};
use sp_std::{borrow::Borrow, prelude::*};
Expand Down Expand Up @@ -427,7 +425,7 @@ pub mod pallet {
*amount,
|details| -> DispatchResult {
debug_assert!(
T::Balance::max_value() - details.supply >= *amount,
details.supply.checked_add(&amount).is_some(),
"checked in prep; qed"
);
details.supply = details.supply.saturating_add(*amount);
Expand All @@ -445,7 +443,7 @@ pub mod pallet {
/// Some asset class was created.
Created { asset_id: T::AssetId, creator: T::AccountId, owner: T::AccountId },
/// Some assets were issued.
Issued { asset_id: T::AssetId, owner: T::AccountId, total_supply: T::Balance },
Issued { asset_id: T::AssetId, owner: T::AccountId, amount: T::Balance },
/// Some assets were transferred.
Transferred {
asset_id: T::AssetId,
Expand Down