Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update tests for 1.66 and switch CI to stable Rust 1.66 #13118

Merged
merged 5 commits into from
Jan 10, 2023

Conversation

rcny
Copy link
Contributor

@rcny rcny commented Jan 10, 2023

Also pins the CI image to the current staging with Rust 1.66, will revert back to the generic production tag after this is merged.

@rcny rcny added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jan 10, 2023
@rcny rcny self-assigned this Jan 10, 2023
@rcny rcny requested a review from a team as a code owner January 10, 2023 15:19
@bkchr
Copy link
Member

bkchr commented Jan 10, 2023

thread 'test_enum' panicked at 'assertion failed: `(left == right)`
  left: `"Enum::VariantUnnamed(1, 2, 3, PhantomData<(derive_no_bound::ImplNone, derive_no_bound::ImplNone)>)"`,
 right: `"Enum::VariantUnnamed(1, 2, 3, PhantomData)"`', frame/support/test/tests/derive_no_bound.rs:212:5

For this issue, can you please just correct the string in the test to correspond to the new expected value?

@bkchr bkchr added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Jan 10, 2023
@paritytech-ci paritytech-ci requested a review from a team January 10, 2023 16:41
@rcny rcny changed the title Update UI tests for 1.66 and switch CI to stable Rust 1.66 Update tests for 1.66 and switch CI to stable Rust 1.66 Jan 10, 2023
@rcny rcny requested a review from a team January 10, 2023 20:29
@ggwpez
Copy link
Member

ggwpez commented Jan 10, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit cb63d3d into master Jan 10, 2023
@paritytech-processbot paritytech-processbot bot deleted the vi-ui-tests-1.66 branch January 10, 2023 21:08
rossbulat pushed a commit that referenced this pull request Jan 11, 2023
* Update UI tests for 1.66

* Fix `test_enum` assertion for Rust 1.66

* Fix another `test_enum` assertion for Rust 1.66

* Fix another `test_enum` assertion for Rust 1.66

* Fix another `test_enum` assertion for Rust 1.66
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
…3118)

* Update UI tests for 1.66

* Fix `test_enum` assertion for Rust 1.66

* Fix another `test_enum` assertion for Rust 1.66

* Fix another `test_enum` assertion for Rust 1.66

* Fix another `test_enum` assertion for Rust 1.66
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
…3118)

* Update UI tests for 1.66

* Fix `test_enum` assertion for Rust 1.66

* Fix another `test_enum` assertion for Rust 1.66

* Fix another `test_enum` assertion for Rust 1.66

* Fix another `test_enum` assertion for Rust 1.66
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants