This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix NFTs pallet's integration issues #13056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsidorenko
added
A0-please_review
joepetrowski
approved these changes
Jan 3, 2023
gilescope
approved these changes
Jan 3, 2023
|
bot merge |
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the integration of the nfts pallet with the upcoming nft-fractionalization pallet here: #13008, I've noticed a few missing things:
MintSettings)pallet_nfts::runtime_benchmarks_enabled! { type Helper = (); }which required adding that line into the lib.rs:sp_core::generate_feature_enabled_macro!(runtime_benchmarks_enabled, feature = "runtime-benchmarks", $);