-
Notifications
You must be signed in to change notification settings - Fork 2.6k
BlockId
removal: refactor: HeaderBackend::header
#12874
BlockId
removal: refactor: HeaderBackend::header
#12874
Conversation
It changes the arguments of: - `HeaderBackend::header`, - `Client::header`, - `PeersClient::header` - `ChainApi::block_header` methods from: `BlockId<Block>` to: `Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)
This may required introduction of dedicated function: header_for_block_num
BlockId
removal: refactor: HeaderBackend::header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A couple of places where this needs changing:
substrate/client/basic-authorship/src/lib.rs
Lines 52 to 54 in e6bbc53
//! let proposer = proposer_factory.init( | |
//! &client.header(&BlockId::number(0)).unwrap().unwrap(), | |
//! ); |
And the readme: https://github.com/paritytech/substrate/blob/master/client/basic-authorship/README.md
bot rebase |
Rebased |
/cmd queue -c fmt |
@michalkucharczyk https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2149145 was started for your command Comment |
@michalkucharczyk Command |
It changes the arguments of `HeaderBackend::expect_header` method from: `BlockId<Block>` to: `Block::Hash`
/cmd queue -c fmt |
@michalkucharczyk https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2161994 was started for your command Comment |
@michalkucharczyk Command |
bot rebase |
Rebased |
/cmd queue -c fmt |
@michalkucharczyk https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2177419 was started for your command Comment |
@michalkucharczyk Command |
bot merge |
Error: Github API says paritytech/cumulus#1977 is not mergeable |
bot merge |
Error: Github API says paritytech/cumulus#1977 is not mergeable |
bot merge |
* BlockId removal: refactor: HeaderBackend::header It changes the arguments of: - `HeaderBackend::header`, - `Client::header`, - `PeersClient::header` - `ChainApi::block_header` methods from: `BlockId<Block>` to: `Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * non-trivial usages of haeder(block_id) refactored This may required introduction of dedicated function: header_for_block_num * fmt * fix * doc fixed * ".git/.scripts/fmt.sh" * BlockId removal: refactor: HeaderBackend::expect_header It changes the arguments of `HeaderBackend::expect_header` method from: `BlockId<Block>` to: `Block::Hash` * ".git/.scripts/fmt.sh" * readme updated * ".git/.scripts/fmt.sh" * fix Co-authored-by: parity-processbot <>
* BlockId removal: refactor: HeaderBackend::header It changes the arguments of: - `HeaderBackend::header`, - `Client::header`, - `PeersClient::header` - `ChainApi::block_header` methods from: `BlockId<Block>` to: `Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * non-trivial usages of haeder(block_id) refactored This may required introduction of dedicated function: header_for_block_num * fmt * fix * doc fixed * ".git/.scripts/fmt.sh" * BlockId removal: refactor: HeaderBackend::expect_header It changes the arguments of `HeaderBackend::expect_header` method from: `BlockId<Block>` to: `Block::Hash` * ".git/.scripts/fmt.sh" * readme updated * ".git/.scripts/fmt.sh" * fix Co-authored-by: parity-processbot <>
BlockId removal: refactor: HeaderBackend::header
It changes the arguments of:
HeaderBackend::header
,Client::header
,PeersClient::header
ChainApi::block_header
methods from:
BlockId<Block>
to:Block::Hash
This PR is part of BlockId::Number refactoring analysis (paritytech/polkadot-sdk#53)
polkadot companion: paritytech/polkadot#6418
cumulus companion: paritytech/cumulus#1977