Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Referenda benchmark assert fix #12866

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Referenda benchmark assert fix #12866

merged 1 commit into from
Dec 7, 2022

Conversation

muharem
Copy link
Contributor

@muharem muharem commented Dec 7, 2022 •
edited
Loading

if SubmissionDeposit is zero, the assertion fails.

polkadot companion: paritytech/polkadot#6360

@muharem muharem added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 7, 2022
@bkchr
Copy link
Member

bkchr commented Dec 7, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 0e2a857

@muharem
Copy link
Contributor Author

muharem commented Dec 7, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 0a27e54 into master Dec 7, 2022
@paritytech-processbot paritytech-processbot bot deleted the muharem-fix-referenda-bench branch December 7, 2022 13:57
@AurevoirXavier AurevoirXavier mentioned this pull request Jan 10, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Feb 14, 2023
Merged
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
@muharem @ltfschoen
bench assert update (paritytech#12866)
e2f493f
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@muharem @ark0f
bench assert update (paritytech#12866)
28bf511
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joepetrowski joepetrowski joepetrowski approved these changes

@tonyalaribe tonyalaribe tonyalaribe approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muharem @bkchr @tonyalaribe @joepetrowski