This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove sandboxing host function interface #12852
Merged
+34
−4,478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
added
A0-please_review
athei
added
the
D3-trivial 🧸
athei
force-pushed
the
at/remove-sandbox
branch
from
fc0026e
to
9fff1f1
Compare
koute
approved these changes
Dec 7, 2022
sergejparity
approved these changes
Dec 7, 2022
alvicsam
approved these changes
Dec 7, 2022
|
bot merge |
ukint-vs
added a commit
to gear-tech/substrate
that referenced
this pull request
Dec 20, 2022
This reverts commit 5722ece.
ukint-vs
added a commit
to gear-tech/substrate
that referenced
this pull request
Dec 22, 2022
This reverts commit 5722ece.
This was referenced Jan 18, 2023
ukint-vs
added a commit
to gear-tech/substrate
that referenced
this pull request
Feb 13, 2023
This reverts commit 5722ece.
ukint-vs
added a commit
to gear-tech/substrate
that referenced
this pull request
Feb 13, 2023
This reverts commit 5722ece.
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
* Remove sandboxing interface * Remove unused struct
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Remove sandboxing interface * Remove unused struct
ukint-vs
added a commit
to gear-tech/substrate
that referenced
this pull request
Apr 13, 2023
This reverts commit 5722ece.
breathx
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 22, 2023
This reverts commit 5722ece.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #12501 we removed the dependence of pallet-contracts on the sandboxing interface. This was its only user and it was never used in production (the interface was never available on validators). pallet-contracts now uses in-runtime wasmi exclusively. In the future when we want to speed up execution we will do that with another interface and probably a more suitable bytecode for singlepass compilation.
This PR also removes the sandboxing functionality and wasmer dependency of
sc-executor. It is a prerequisite for a larger refactoring of that crate that should make it much simpler. Sandboxing and execution of runtime should not be conflated in this way.This removes a host function that was never available on validators and is not used by any project I know of. I add the newhostfunction label just in case, though.