This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Set WASM_BUILD_WORKSPACE_HINT before starting CI jobs #12816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this enables wasm-builder to find the Cargo.lock from within generated packages
joao-paulo-parity
added
A2-insubstantial
joao-paulo-parity
changed the title
|
By https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2105754#L1490 I think we need an adjustment for https://github.com/paritytech/pipeline-scripts/blob/1978a96e208a06866396492394b85940ae6a5444/check_dependent_project.sh#L436. Thankfully it's a simple one: paritytech/pipeline-scripts#87. |
|
Moving to Draft to prevent accidental merges until paritytech/pipeline-scripts#87 is merged. |
bkchr
approved these changes
Dec 5, 2022
|
Moving to Draft again because I messed up the variable name in paritytech/pipeline-scripts#87. My bad. |
sergejparity
approved these changes
Dec 8, 2022
alvicsam
suggested changes
Dec 16, 2022
Co-authored-by: Alexander Samusev <[email protected]>
alvicsam
approved these changes
Dec 16, 2022
|
bot merge |
|
Waiting for commit status. |
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
* set WASM_BUILD_WORKSPACE_HINT this enables wasm-builder to find the Cargo.lock from within generated packages * wip: try out paritytech/pipeline-scripts#90 * wip: fixup * wip * revert ci skip * set up WASM_BUILD_WORKSPACE_HINT for .kubernetes-env as well * Update scripts/ci/gitlab/pipeline/publish.yml Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: Alexander Samusev <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* set WASM_BUILD_WORKSPACE_HINT this enables wasm-builder to find the Cargo.lock from within generated packages * wip: try out paritytech/pipeline-scripts#90 * wip: fixup * wip * revert ci skip * set up WASM_BUILD_WORKSPACE_HINT for .kubernetes-env as well * Update scripts/ci/gitlab/pipeline/publish.yml Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: Alexander Samusev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CI jobs currently display warnings such as those ones:
Despite those warnings, the jobs still succeed.
Solution
Set up
WASM_BUILD_WORKSPACE_HINT="$PWD"before starting the jobs.