Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Assets Pallet: reintroduce fungibles::Destroy trait #12690

Closed
wants to merge 78 commits into from
Closed

Assets Pallet: reintroduce fungibles::Destroy trait #12690

wants to merge 78 commits into from

Commits on Sep 20, 2022

  1. Support repeated destroys to safely destroy large assets

    @tonyalaribe
    tonyalaribe committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    6a9d9d1 View commit details
    Browse the repository at this point in the history

  2. require freezing accounts before destroying

    @tonyalaribe
    tonyalaribe committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    7db1fd5 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. support only deleting asset as final stage when there's no assets left

    @tonyalaribe
    tonyalaribe committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    cbe14b2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into aa/safely-destroy-large-assets

    @tonyalaribe
    tonyalaribe authored Sep 21, 2022
    Configuration menu
    Copy the full SHA
    001eaef View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. pre: introduce the RemoveKeyLimit config parameter

    @tonyalaribe
    tonyalaribe committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    1beae07 View commit details
    Browse the repository at this point in the history

  2. debug_ensure empty account in the right if block

    @tonyalaribe
    tonyalaribe committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    c9ce171 View commit details
    Browse the repository at this point in the history

  3. update to having separate max values for accounts and approvals

    @tonyalaribe
    tonyalaribe committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    3067e38 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. add tests and use RemoveKeyLimit constant

    @tonyalaribe
    tonyalaribe committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    7c4f610 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. add useful comments to the extrinsics, and calculate returned weight

    @tonyalaribe
    tonyalaribe committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    aca497f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:paritytech/substrate into aa/safe… 

    …ly-destroy-large-assets
    @tonyalaribe
    tonyalaribe committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    634345a View commit details
    Browse the repository at this point in the history

  3. add benchmarking for start_destroy and finish destroy

    @tonyalaribe
    tonyalaribe committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    93d886d View commit details
    Browse the repository at this point in the history

  4. push failing benchmark logic

    @tonyalaribe
    tonyalaribe committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    2d3b650 View commit details
    Browse the repository at this point in the history

  5. add benchmark tests for new functions

    @tonyalaribe
    tonyalaribe committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    5a612d1 View commit details
    Browse the repository at this point in the history

  6. update weights via local benchmarks

    @tonyalaribe
    tonyalaribe committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    b961255 View commit details
    Browse the repository at this point in the history

  7. remove extra weight file

    @tonyalaribe
    tonyalaribe committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    91e3c18 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Update frame/assets/src/lib.rs 

    Co-authored-by: joe petrowski <[email protected]>
    @tonyalaribe @joepetrowski
    tonyalaribe and joepetrowski authored Sep 28, 2022
    Configuration menu
    Copy the full SHA
    60f954a View commit details
    Browse the repository at this point in the history

  2. Update frame/assets/src/types.rs 

    Co-authored-by: joe petrowski <[email protected]>
    @tonyalaribe @joepetrowski
    tonyalaribe and joepetrowski authored Sep 28, 2022
    Configuration menu
    Copy the full SHA
    ce00b5b View commit details
    Browse the repository at this point in the history

  3. Update frame/assets/src/lib.rs 

    Co-authored-by: joe petrowski <[email protected]>
    @tonyalaribe @joepetrowski
    tonyalaribe and joepetrowski authored Sep 28, 2022
    Configuration menu
    Copy the full SHA
    5492b6d View commit details
    Browse the repository at this point in the history

  4. effect some changes from codereview

    @tonyalaribe
    tonyalaribe committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    bc20a6c View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. use NotFrozen error

    @tonyalaribe
    tonyalaribe committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    6ceb592 View commit details
    Browse the repository at this point in the history

  2. remove origin checks, as anyone can complete destruction after owner … 

    …has begun the process; Add live check for other extrinsics
    @tonyalaribe
    tonyalaribe committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    2edac52 View commit details
    Browse the repository at this point in the history

  3. fix comments about Origin behaviour

    @tonyalaribe
    tonyalaribe committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    aa2aecf View commit details
    Browse the repository at this point in the history

  4. add AssetStatus docs

    @tonyalaribe
    tonyalaribe committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    10fdd90 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. modularize logic to allow calling logic in on_idle and on_initialize … 

    …hooks
    @tonyalaribe
    tonyalaribe committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    139d2e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. introduce simple migration for assets details

    @tonyalaribe
    tonyalaribe committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    597f532 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into aa/safely-destroy-l… 

    …arge-assets
    parity-processbot committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    a09e762 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. reintroduce logging in the migrations

    @tonyalaribe
    tonyalaribe committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    70930ac View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. move deposit_Event out of the mutate block

    @tonyalaribe
    tonyalaribe committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    dc4a243 View commit details
    Browse the repository at this point in the history

  2. Update frame/assets/src/functions.rs 

    Co-authored-by: Muharem Ismailov <[email protected]>
    @tonyalaribe @muharem
    tonyalaribe and muharem authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    05d778d View commit details
    Browse the repository at this point in the history

  3. Update frame/assets/src/migration.rs 

    Co-authored-by: Muharem Ismailov <[email protected]>
    @tonyalaribe @muharem
    tonyalaribe and muharem authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    62d4f13 View commit details
    Browse the repository at this point in the history

  4. move AssetNotLive checkout out of the mutate blocks

    @tonyalaribe
    tonyalaribe committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    e9e108b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'aa/safely-destroy-large-assets' of github.com:paritytec… 

    …h/substrate into aa/safely-destroy-large-assets
    @tonyalaribe
    tonyalaribe committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    5df4a62 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. rename RemoveKeysLimit to RemoveItemsLimit

    @tonyalaribe
    tonyalaribe committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    544ac52 View commit details
    Browse the repository at this point in the history

  2. update docs

    @tonyalaribe
    tonyalaribe committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    9206acf View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. fix event name in benchmark

    @tonyalaribe
    tonyalaribe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    29c7745 View commit details
    Browse the repository at this point in the history

  2. fix cargo fmt.

    @tonyalaribe
    tonyalaribe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    2986f29 View commit details
    Browse the repository at this point in the history

  3. fix lint in benchmarking

    @tonyalaribe
    tonyalaribe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    6ac84a1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:paritytech/substrate into aa/safe… 

    …ly-destroy-large-assets
    @tonyalaribe
    tonyalaribe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    1f2930f View commit details
    Browse the repository at this point in the history

  5. Empty commit to trigger CI

    @tonyalaribe
    tonyalaribe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    791aa7f View commit details
    Browse the repository at this point in the history

  6. Update frame/assets/src/lib.rs 

    Co-authored-by: Oliver Tale-Yazdi <[email protected]>
    @tonyalaribe @ggwpez
    tonyalaribe and ggwpez authored Oct 14, 2022
    Configuration menu
    Copy the full SHA
    450a698 View commit details
    Browse the repository at this point in the history

  7. Update frame/assets/src/lib.rs 

    Co-authored-by: Oliver Tale-Yazdi <[email protected]>
    @tonyalaribe @ggwpez
    tonyalaribe and ggwpez authored Oct 14, 2022
    Configuration menu
    Copy the full SHA
    3daef79 View commit details
    Browse the repository at this point in the history

  8. Update frame/assets/src/functions.rs 

    Co-authored-by: Oliver Tale-Yazdi <[email protected]>
    @tonyalaribe @ggwpez
    tonyalaribe and ggwpez authored Oct 14, 2022
    Configuration menu
    Copy the full SHA
    ea34cf5 View commit details
    Browse the repository at this point in the history

  9. Update frame/assets/src/functions.rs 

    Co-authored-by: Oliver Tale-Yazdi <[email protected]>
    @tonyalaribe @ggwpez
    tonyalaribe and ggwpez authored Oct 14, 2022
    Configuration menu
    Copy the full SHA
    84cbb47 View commit details
    Browse the repository at this point in the history

  10. Update frame/assets/src/functions.rs 

    Co-authored-by: Oliver Tale-Yazdi <[email protected]>
    @tonyalaribe @ggwpez
    tonyalaribe and ggwpez authored Oct 14, 2022
    Configuration menu
    Copy the full SHA
    082a10c View commit details
    Browse the repository at this point in the history

  11. Update frame/assets/src/lib.rs 

    Co-authored-by: Oliver Tale-Yazdi <[email protected]>
    @tonyalaribe @ggwpez
    tonyalaribe and ggwpez authored Oct 14, 2022
    Configuration menu
    Copy the full SHA
    e84d5ae View commit details
    Browse the repository at this point in the history

  12. Update frame/assets/src/functions.rs 

    Co-authored-by: Oliver Tale-Yazdi <[email protected]>
    @tonyalaribe @ggwpez
    tonyalaribe and ggwpez authored Oct 14, 2022
    Configuration menu
    Copy the full SHA
    78cde15 View commit details
    Browse the repository at this point in the history

  13. effect change suggested during code review

    @tonyalaribe
    tonyalaribe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    c6470fb View commit details
    Browse the repository at this point in the history

  14. move limit to a single location

    @tonyalaribe
    tonyalaribe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    85e50b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Merge branch 'master' of github.com:paritytech/substrate into aa/safe… 

    …ly-destroy-large-assets
    @tonyalaribe
    tonyalaribe committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    c97e850 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Update frame/assets/src/functions.rs 

    Co-authored-by: joe petrowski <[email protected]>
    @tonyalaribe @joepetrowski
    tonyalaribe and joepetrowski authored Oct 18, 2022
    Configuration menu
    Copy the full SHA
    df27e0b View commit details
    Browse the repository at this point in the history

  2. rename events

    @tonyalaribe
    tonyalaribe committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    ca9fa2e View commit details
    Browse the repository at this point in the history

  3. fix weight typo, using rocksdb instead of T::DbWeight. Pending genera… 

    …ting weights
    @tonyalaribe
    tonyalaribe committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    9609f13 View commit details
    Browse the repository at this point in the history

  4. switch to using dead_account.len()

    @tonyalaribe
    tonyalaribe committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    26d27cc View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. rename event in the benchmarks

    @tonyalaribe
    tonyalaribe committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    72ec8f8 View commit details
    Browse the repository at this point in the history

  2. empty to retrigger CI

    @tonyalaribe
    tonyalaribe committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    ee30cf8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:paritytech/substrate into aa/safe… 

    …ly-destroy-large-assets
    @tonyalaribe
    tonyalaribe committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    87a7877 View commit details
    Browse the repository at this point in the history

  4. trigger CI to check cumulus dependency

    @tonyalaribe
    tonyalaribe committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    773212e View commit details
    Browse the repository at this point in the history

  5. trigger CI for dependent cumulus

    @tonyalaribe
    tonyalaribe committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    a4be57f View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. Merge branch 'master' into aa/safely-destroy-large-assets

    @tonyalaribe
    tonyalaribe authored Oct 22, 2022
    Configuration menu
    Copy the full SHA
    111da0e View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Update frame/assets/src/migration.rs 

    Co-authored-by: Oliver Tale-Yazdi <[email protected]>
    @tonyalaribe @ggwpez
    tonyalaribe and ggwpez authored Oct 24, 2022
    Configuration menu
    Copy the full SHA
    9c06bb8 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. move is-frozen to the assetStatus enum (#12547)

    @tonyalaribe
    tonyalaribe authored Oct 26, 2022
    Configuration menu
    Copy the full SHA
    4eef069 View commit details
    Browse the repository at this point in the history

  2. add pre and post migration hooks

    @tonyalaribe
    tonyalaribe committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    486814f View commit details
    Browse the repository at this point in the history

  3. update do_transfer logic to add new assert for more correct error mes… 

    …sages
    @tonyalaribe
    tonyalaribe committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c185cb0 View commit details
    Browse the repository at this point in the history

  4. trigger CI

    @tonyalaribe
    tonyalaribe committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    91095af View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. switch checking AssetStatus from checking Destroying state to checkin… 

    …g live state
    @tonyalaribe
    tonyalaribe committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    9ef3c2b View commit details
    Browse the repository at this point in the history

  2. fix error type in tests from Frozen to AssetNotLive

    @tonyalaribe
    tonyalaribe committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    6165576 View commit details
    Browse the repository at this point in the history

  3. trigger CI

    @tonyalaribe
    tonyalaribe committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    7811b62 View commit details
    Browse the repository at this point in the history

  4. change ensure check for fn reducible_balance()

    @tonyalaribe
    tonyalaribe committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    cd3e28d View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. change the error type to Error:<T,I>::IncorrectStatus to be clearer

    @tonyalaribe
    tonyalaribe committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    aee596e View commit details
    Browse the repository at this point in the history

  2. Trigger CI

    @tonyalaribe
    tonyalaribe committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    30814df View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into aa/safely-destroy-large-assets

    @tonyalaribe
    tonyalaribe committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    9b653a5 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Merge branch 'master' into aa/safely-destroy-large-assets

    @tonyalaribe
    tonyalaribe authored Nov 10, 2022
    Configuration menu
    Copy the full SHA
    57fe747 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. reintroduce the destroy trait

    @tonyalaribe
    tonyalaribe committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    9580cea View commit details
    Browse the repository at this point in the history

  2. modify fungibles::Destroy public trait

    @tonyalaribe
    tonyalaribe committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    b6cca71 View commit details
    Browse the repository at this point in the history

  3. reintroduce trait

    @tonyalaribe
    tonyalaribe committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    9a18340 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. update relevant trait documentation

    @tonyalaribe
    tonyalaribe committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    01f3fe3 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. update docs formatting

    @tonyalaribe
    tonyalaribe committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    a408a3d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into aa/reintroduce-destroy-into-fungibles-trait2

    @tonyalaribe
    tonyalaribe authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    c4cb5d0 View commit details
    Browse the repository at this point in the history