This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[Fix] Benchmark issue in staking #12290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruseinov
added
E9-blocker ⛔️
C1-low
bkchr
approved these changes
Sep 18, 2022
|
And you are sure that this isn't used in the benchmarks? Aka will not panic? |
gilescope
approved these changes
Sep 18, 2022
It's not, mainly because those implementations are used for testing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocks paritytech/polkadot#5930 and potentially all the polkadot builds that depend on latest substrate master.
polkadot companion: paritytech/polkadot#5930
^ not really, but we need it for the dependent build to pass