Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Move Get and bounded types to sp-core #12203

Merged
merged 4 commits into from
Sep 7, 2022

Conversation

KiChjang
Copy link
Contributor

@KiChjang KiChjang commented Sep 7, 2022

This PR moves the Get traits, bounded types and associated macros to sp-core from sp-runtime.

The motivation here is a recognition that these types and traits don't really require a notion of the runtime, and are simply plain Rust new types that can be generally applied everywhere, which then makes it easier for new crates to resolve circular dependency issues as they do not necessarily need to depend on sp-runtime, but rather something even more basic and primitive than it.

@KiChjang KiChjang added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Sep 7, 2022
@bkchr
Copy link
Member

bkchr commented Sep 7, 2022

Can you be more specific on why this is needed? Where are we having circular depedencies?

Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like basti's question to be answered, but it makes sense to me

@KiChjang
Copy link
Contributor Author

KiChjang commented Sep 7, 2022

@bkchr I'm in the middle of creating a new crate called sp-weights, with the intention of moving the Weight struct to it. The Get trait lives in sp-runtime, and some of the Weight impls depend upon it, so before this PR, sp-weights would have to depend upon sp-runtime, which could be problematic as the DispatchInfo stuff in sp-runtime depends on the Weight struct as well, creating a circular dependency.

@KiChjang
Copy link
Contributor Author

KiChjang commented Sep 7, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 5e2ffeb into master Sep 7, 2022
@paritytech-processbot paritytech-processbot bot deleted the kckyeung/move-get-to-core branch September 7, 2022 15:41
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Move Get and bounded types to sp-core

* Fixes

* cargo fmt

* Fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants