This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Allow specifying immediate finalize for manual-seal
#12106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
added
A0-please_review
cmichi
force-pushed
the
cmichi-add-immediate-finalize-option-to-manual-seal
branch
from
d1a581a
to
be258fe
Compare
bkchr
approved these changes
Aug 25, 2022
athei
approved these changes
Aug 25, 2022
|
@bkchr Thanks for the approval, CI is failing due to some clippy stuff unrelated to this PR: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/1773294. Could you force merge? Or how to continue? |
|
You just push a Fix. |
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
athei
added
D2-notlive 💤
|
bot merge |
paritytech-processbot
bot
deleted the
cmichi-add-immediate-finalize-option-to-manual-seal
branch
1 task
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
Co-authored-by: Alexander Theißen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
manual-sealengine seals blocks automatically for each issued transaction, but doesn't finalize them until an RPCfinalize_blockcall is explicitly issued.We need automatic finalization for
substrate-contracts-node, where we usemanual-sealfor testing and CI purposes. Specifically I need this automatic finalization for introducing E2E testing for ink! smart contract developers (use-ink/ink#1234).To avoid breaking changes to the API this PR introduces a
fn run_instant_seal_and_finalize, analog tofn run_instant_sealright above it.