This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
beefy: initialize voter from genesis and fix initial sync #11959
Merged
Commits on Aug 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for eb36f51 - Browse repository at this point
Copy the full SHA eb36f51View commit details
Commits on Aug 2, 2022
-
client/beefy: initialize voter from genesis
Now that we have justifications import, we can drop the "lean beefy" behaviour and start building justifications chain from Genesis with containing all past sessions' mandatory blocks justifications.
Configuration menu - View commit details
-
Copy full SHA for 2057593 - Browse repository at this point
Copy the full SHA 2057593View commit details -
client/beefy: walk finality tree_route to catch session changes
Signed-off-by: acatangiu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 428dc84 - Browse repository at this point
Copy the full SHA 428dc84View commit details -
client/beefy: fix block import
During initial block import blocks are not finalized, so trying to validate and append justifications within block import fails (for initial network sync imported blocks). Changes: - Move justification validation to _after_ `inner.block_import()`, so block is imported in backend and runtime api can be called to get the BEEFY authorities for said block. - Move append-to-backend for imported BEEFY justification to voter, because it already has the required logic to BEEFY-finalize blocks only after GRANDPA finalized them. - Mark voting rounds as concluded when finalizing through imported justifications as well as when finalizing through voting. Signed-off-by: acatangiu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d2c028a - Browse repository at this point
Copy the full SHA d2c028aView commit details -
client/beefy: valid justifications are one per block number
The only way we'd get _different_ _validated_ justifications for same block number is if authorities are double voting, which will be handled later.
Configuration menu - View commit details
-
Copy full SHA for f853a71 - Browse repository at this point
Copy the full SHA f853a71View commit details
Commits on Aug 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 396ba91 - Browse repository at this point
Copy the full SHA 396ba91View commit details
Commits on Aug 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 388391f - Browse repository at this point
Copy the full SHA 388391fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c7c17d - Browse repository at this point
Copy the full SHA 1c7c17dView commit details
Commits on Aug 5, 2022
-
client/beefy: correct voter initialization
BEEFY voter should resume voting from either: - last BEEFY finalized block, - session start, whichever is closest to head. Signed-off-by: acatangiu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 924f4d0 - Browse repository at this point
Copy the full SHA 924f4d0View commit details -
client/beefy: test voter initialization
Signed-off-by: acatangiu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bd89534 - Browse repository at this point
Copy the full SHA bd89534View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ffec98 - Browse repository at this point
Copy the full SHA 5ffec98View commit details
Commits on Aug 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1b013fb - Browse repository at this point
Copy the full SHA 1b013fbView commit details
Commits on Sep 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6a17e76 - Browse repository at this point
Copy the full SHA 6a17e76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71ae1bf - Browse repository at this point
Copy the full SHA 71ae1bfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.