This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Catch panics on the FFI boundary between the runtime and the host for wasmtime
#11189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koute
added
A0-please_review
bkchr
approved these changes
Apr 8, 2022
bkchr
reviewed
Apr 8, 2022
|
bot merge |
|
Waiting for commit status. |
|
Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count |
![paritytech-processbot[bot]](https://avatars.githubusercontent.com/in/144942?s=60&v=4){kind=small}
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
… `wasmtime` (paritytech#11189) * Catch panics on the FFI boundary between the runtime and the host for `wasmtime` * Use an already existing test runtime function * Merge the tests together
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
… `wasmtime` (paritytech#11189) * Catch panics on the FFI boundary between the runtime and the host for `wasmtime` * Use an already existing test runtime function * Merge the tests together
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the runtime calls into the host and the host panics we're left with no backtrace from within the runtime since the panic is only caught here after the whole execution context is already dropped. (And the host functions can panic.)
This PR makes it so that we catch any panics on the FFI boundary between the runtime and the host, and turn that into a trap. This allows us to extract and print out the backtrace from within the runtime as part of the error message and see what exactly within the runtime called the host function which panicked.
This is done only for
wasmtimesince at this timewasmidoesn't support backtraces anyway.