-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Change default execution strategies to Wasm
#11170
Conversation
This pr changes all default execution strategies to `Wasm`. This is basically a deprecation of the native runtime. While the native runtime isn't removed and can still be used, it will not be used anymore by default. This will also improve the usage for people who want to run random commits, which most often forget to run with `--execution wasm`. Otherwise they often run into storage root mismatches because of using the native runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we also using wasmtime by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README of staking-miner might need some fixup in the "Testing locally" section, too? And the bridges repo also overrides --execution
in the compose files.
If the feature is enabled, yes. |
This doesn't break anything, it just changes the default. You can still use the cli argument to override these values. |
I will assume parachains doesn't need to do anything and will inherent this default once we upgrade Substrate version? |
Exactly. These are the default values for the cli flags. As long as you don't run your node with any |
Just a point worst mentioning: wasm strategy drastically reduces performance of archive nodes who have public exposed endpoint under high number of requests. |
This pr changes all default execution strategies to `Wasm`. This is basically a deprecation of the native runtime. While the native runtime isn't removed and can still be used, it will not be used anymore by default. This will also improve the usage for people who want to run random commits, which most often forget to run with `--execution wasm`. Otherwise they often run into storage root mismatches because of using the native runtime.
This pr changes all default execution strategies to `Wasm`. This is basically a deprecation of the native runtime. While the native runtime isn't removed and can still be used, it will not be used anymore by default. This will also improve the usage for people who want to run random commits, which most often forget to run with `--execution wasm`. Otherwise they often run into storage root mismatches because of using the native runtime.
This pr changes all default execution strategies to
Wasm
. This is basically a deprecation of thenative runtime. While the native runtime isn't removed and can still be used, it will not be used
anymore by default.
This will also improve the usage for people who want to run random commits, which most often forget
to run with
--execution wasm
. Otherwise they often run into storage root mismatches because ofusing the native runtime.