Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

relax input conditions of fixed::checked_from_integer #11159

Merged
merged 2 commits into from
Apr 7, 2022
Merged

relax input conditions of fixed::checked_from_integer #11159

merged 2 commits into from
Apr 7, 2022

Conversation

kianenigma
Copy link
Contributor

fixes #10572

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 4, 2022
@kianenigma kianenigma mentioned this pull request Apr 4, 2022
Closed
ggwpez
ggwpez approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good. Hopefully this won't affect any calls,
as the CI is currently indicating.

@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit e6ae0b0 into master Apr 7, 2022
@paritytech-processbot paritytech-processbot bot deleted the kiz-relax-fixed-from branch April 7, 2022 07:46
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
@kianenigma @DaviRain-Su
relax input conditions of fixed::checked_from_integer (paritytech#11159)
4412fce 
* relax input conditions of fixed::checked_from_integer

* Fix build
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@kianenigma @ark0f
relax input conditions of fixed::checked_from_integer (paritytech#11159)
d3c6c4c 
* relax input conditions of fixed::checked_from_integer

* Fix build
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

from_{integer} for FixedPointNumbers
3 participants
@kianenigma @bkchr @ggwpez