Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

WIP removing native runtime #10872

Closed
wants to merge 15 commits into from
Closed

WIP removing native runtime #10872

wants to merge 15 commits into from

Conversation

arkpar
Copy link
Member

@arkpar arkpar commented Feb 17, 2022

First steps towards paritytech/polkadot-sdk#62

Here I've removed RuntimeApi generic from everywhere. All runtime APIs are now implemented for a concrete struct RuntimeApi. This implementation is generated by declare_runtime_api

Genesis data for various types of chain specs, such as "development", "local testnet" and "staging" is now provided by the runtime.

@bkchr Please check if this makes sense.

@arkpar arkpar added the A3-in_progress Pull request is in progress. No review needed at this stage. label Feb 17, 2022
Cargo.toml Outdated
@@ -276,8 +275,8 @@ yamux = { opt-level = 3 }
zeroize = { opt-level = 3 }

[profile.release]
# Substrate runtime requires unwinding.
panic = "unwind"
panic = "abort"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pepyakin Do we need panic = "unwind" for wasmtime?
Otherwise, with no native runtime, we can switch to panic = "abort" and gain better performance and significantly reduced binary size.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you mean whether traps generated by wasm code in wasmtime require unwind, and the answer is no, it works via a setjmp/longjmp like approach.

However, I think we should do this as a follow-up. The reason is, this requires some research to proof that we do not rely on this property somewhere else, because it was already there. I personally cannot recall any but it's better be safe than sorry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stale
Copy link

stale bot commented Mar 26, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Mar 26, 2022
@bkchr bkchr removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Apr 3, 2022
@stale
Copy link

stale bot commented May 3, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label May 3, 2022
@stale stale bot closed this May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A3-in_progress Pull request is in progress. No review needed at this stage. A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants