This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
bench-cli: Support JSON output
#10771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
added
A0-please_review
Polkadot does not compile otherwise. Signed-off-by: Oliver Tale-Yazdi <[email protected]>
shawntabrizi
reviewed
Feb 1, 2022
shawntabrizi
approved these changes
Feb 1, 2022
bkchr
reviewed
Feb 1, 2022
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
bkchr
approved these changes
Feb 2, 2022
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
bot merge |
agryaznov
pushed a commit
to agryaznov/substrate
that referenced
this pull request
Feb 4, 2022
* Add dependencies Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Make benchmark results serializable Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add `--json[-file]` options Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Enable JSON output Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Use specific serde version Polkadot does not compile otherwise. Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Review comments Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Review comment: fs::write Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Wizdave97
pushed a commit
to ComposableFi/substrate
that referenced
this pull request
Feb 4, 2022
* Add dependencies Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Make benchmark results serializable Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add `--json[-file]` options Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Enable JSON output Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Use specific serde version Polkadot does not compile otherwise. Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Review comments Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Review comment: fs::write Signed-off-by: Oliver Tale-Yazdi <[email protected]>
gilescope
added a commit
to paritytech/cumulus
that referenced
this pull request
Feb 21, 2022
we should be using production profile for benchmarks. --raw does not exist: paritytech/substrate#10771
|
Docs should be updated accordingly: https://docs.substrate.io/v3/runtime/benchmarking/#command-argument They advice to use In what repo should I open a new issue? |
gilescope
added a commit
to paritytech/cumulus
that referenced
this pull request
Feb 21, 2022
we should be using production profile for benchmarks. --raw does not exist: paritytech/substrate#10771
I think we just ping DevHub on chat and ask there. @NachoPal |
gilescope
added a commit
to gilescope/substrate-developer-hub.github.io
that referenced
this pull request
Feb 22, 2022
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Add dependencies Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Make benchmark results serializable Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add `--json[-file]` options Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Enable JSON output Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Use specific serde version Polkadot does not compile otherwise. Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Review comments Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Review comment: fs::write Signed-off-by: Oliver Tale-Yazdi <[email protected]>
WebWizrd8
added a commit
to WebWizrd8/cumulus
that referenced
this pull request
Nov 21, 2022
we should be using production profile for benchmarks. --raw does not exist: paritytech/substrate#10771
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Add dependencies Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Make benchmark results serializable Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add `--json[-file]` options Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Enable JSON output Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Use specific serde version Polkadot does not compile otherwise. Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Review comments Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Review comment: fs::write Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current output of the benchmarking-cli uses a mix of human-readable text and csv.
This MR updates it JSON to make it machine readable. Maybe needs the "breaking change" label, not sure.
--jsonto the benchmarking-cli: Print the raw data as json to stdout--json-file=path: Write the raw data into a json file--rawoptionExample balances.json.txt