Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

reset events before apply runtime upgrade #10620

Merged
merged 6 commits into from
Jan 12, 2022

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Jan 9, 2022

closes #10603

polkadot companion: paritytech/polkadot#4696
cumulus companion: paritytech/cumulus#894

@xlc xlc requested a review from andresilva as a code owner January 9, 2022 21:19
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just some nitpicks.

frame/system/src/lib.rs Outdated Show resolved Hide resolved
frame/executive/src/lib.rs Show resolved Hide resolved
@bkchr
Copy link
Member

bkchr commented Jan 10, 2022

It also doesn't compile.

@bkchr bkchr added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jan 10, 2022
@xlc xlc requested a review from athei as a code owner January 10, 2022 09:40
frame/system/src/lib.rs Outdated Show resolved Hide resolved
@bkchr
Copy link
Member

bkchr commented Jan 11, 2022

@xlc we need a companion for this.

@bkchr
Copy link
Member

bkchr commented Jan 12, 2022

bot merge

grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
* reset events before apply runtime upgrade

* fix tests

* add test

* update comment

* Update frame/system/src/lib.rs

* trigger CI

Co-authored-by: Bastian Köcher <[email protected]>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* reset events before apply runtime upgrade

* fix tests

* add test

* update comment

* Update frame/system/src/lib.rs

* trigger CI

Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events from on_runtime_upgrade are unavailable
3 participants