Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

SlotDuration: Always fetch the slot duration from the runtime #10509

Merged
merged 4 commits into from
Dec 20, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Dec 17, 2021

The slot duration should always be fetched from the runtime instead of being cached in the db. The
slot duration is only fetched on startup of the node, so the performance isn't that important. This
is especially helpful for the case when the slot duration of a chain should be changed through a
runtime upgrade (there be dragons, so take care).

polkadot companion: paritytech/polkadot#4556
cumulus companion: paritytech/cumulus#864

The slot duration should always be fetched from the runtime instead of being cached in the db. The
slot duration is only fetched on startup of the node, so the performance isn't that important. This
is especially helpful for the case when the slot duration of a chain should be changed through a
runtime upgrade (there be dragons, so take care).
@bkchr bkchr added A0-please_review Pull request needs code review. B5-clientnoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 17, 2021
bkchr added a commit to paritytech/polkadot that referenced this pull request Dec 17, 2021
@andresilva
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Error: It's not possible to meet the minimal approval count of 1 in paritytech/cumulus#864

@bkchr
Copy link
Member Author

bkchr commented Dec 20, 2021

bot merge

@paritytech-processbot
Copy link

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@paritytech-processbot paritytech-processbot bot merged commit d18705e into master Dec 20, 2021
@paritytech-processbot paritytech-processbot bot deleted the bkchr-slot-duration-fetch-always branch December 20, 2021 19:49
paritytech-processbot bot pushed a commit to paritytech/polkadot that referenced this pull request Dec 20, 2021
* Substrate companion for change slot duration fetching

paritytech/substrate#10509

* Fix bridges

* update lockfile for substrate

Co-authored-by: parity-processbot <>
paritytech-processbot bot pushed a commit to paritytech/cumulus that referenced this pull request Dec 20, 2021
* Substrate companion for fetching slot duration

paritytech/substrate#10509

* update lockfile for substrate

* Update

Co-authored-by: parity-processbot <>
drahnr pushed a commit to paritytech/polkadot that referenced this pull request Jan 4, 2022
* Substrate companion for change slot duration fetching

paritytech/substrate#10509

* Fix bridges

* update lockfile for substrate

Co-authored-by: parity-processbot <>
Wizdave97 pushed a commit to ComposableFi/polkadot that referenced this pull request Feb 3, 2022
* Substrate companion for change slot duration fetching

paritytech/substrate#10509

* Fix bridges

* update lockfile for substrate

Co-authored-by: parity-processbot <>
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
…tech#10509)

* SlotDuration: Always fetch the slot duration from the runtime

The slot duration should always be fetched from the runtime instead of being cached in the db. The
slot duration is only fetched on startup of the node, so the performance isn't that important. This
is especially helpful for the case when the slot duration of a chain should be changed through a
runtime upgrade (there be dragons, so take care).

* Fix docs

* Remove logging

* Fix warning
AurevoirXavier added a commit to darwinia-network/darwinia-common that referenced this pull request Sep 8, 2022
WebWizrd8 added a commit to WebWizrd8/cumulus that referenced this pull request Nov 21, 2022
* Substrate companion for fetching slot duration

paritytech/substrate#10509

* update lockfile for substrate

* Update

Co-authored-by: parity-processbot <>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
…tech#10509)

* SlotDuration: Always fetch the slot duration from the runtime

The slot duration should always be fetched from the runtime instead of being cached in the db. The
slot duration is only fetched on startup of the node, so the performance isn't that important. This
is especially helpful for the case when the slot duration of a chain should be changed through a
runtime upgrade (there be dragons, so take care).

* Fix docs

* Remove logging

* Fix warning
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants