This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Manual Seal: Calculate the block's post hash #10498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
added
A2-insubstantial
kianenigma
approved these changes
Dec 16, 2021
bkchr
added
the
D3-trivial 🧸
JoshOrndorff
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Dec 16, 2021
JoshOrndorff
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Dec 16, 2021
gilescope
reviewed
Jan 8, 2022
| // Make sure we return the same post-hash that will be calculated when importing the block | ||
| // This is important in case the digest_provider added any signature, seal, ect. | ||
| let mut post_header = header.clone(); | ||
| post_header.digest_mut().logs.extend(params.post_digests.iter().cloned()); |
There was a problem hiding this comment.
wondering if there's any security risk to calculating the hash up front at this point rather than cloning the header and doing the hash later on?
There was a problem hiding this comment.
Why should that be a security risk?
|
@JoshOrndorff what is the status of a test? |
bkchr
approved these changes
Jan 10, 2022
|
bot merge |
|
Waiting for commit status. |
tgmichel
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Jan 10, 2022
|
Thank you @tgmichel |
tgmichel
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Jan 18, 2022
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* calculate the post hash * Add test Co-authored-by: tgmichel <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* calculate the post hash * Add test Co-authored-by: tgmichel <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes manual seal so that the block hash it returns to the RPC caller is the same hash that can later be used to look the block up in the database.
Previously manual seal was returning the hash of the block as was returned from the
Producer. That is to say before any signature or other kind of seal was added.This bug was caught by Moonbeam's CI, which also shows that this changes fixes it.
cc @seunlanlege