This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix update_lock #10485
Merged
Fix update_lock #10485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
|
Note the build error is unrelated. |
shawntabrizi
approved these changes
Dec 14, 2021
|
Cumulus error unrelated. |
viniul
added
D1-audited 👍
seunlanlege
pushed a commit
to seunlanlege/substrate
that referenced
this pull request
Dec 17, 2021
* Fix update_lock * Fixes * Formatting * add `inc_consumers_without_limits` to session too Co-authored-by: Shawn Tabrizi <[email protected]>
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Fix update_lock * Fixes * Formatting * add `inc_consumers_without_limits` to session too Co-authored-by: Shawn Tabrizi <[email protected]>
AurevoirXavier
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Sep 8, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Fix update_lock * Fixes * Formatting * add `inc_consumers_without_limits` to session too Co-authored-by: Shawn Tabrizi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_lockexpects thatinc_consumerscannot fail if the account is funded, an assumption which theMaxConsumerslimit breaks.This introduce a new function
inc_consumers_without_limit, which provides the old functionality. This makesMaxConsumersa soft limit, able to be breached under limited situations. Specifically, the actual maximum number of consumers isMaxConsumersplus the callable instances ofinc_consumers_without_limit, which for the Polkadot chain is1(owing to the single instance of theLockspallet).For now we default to just doubling it in the case of a single
ConstU32MaxConsumersdefinition which is fine for anything non-production. For live chains, we might want to tailor it a little more using the pair-Getter impl. It doesn't really matter yet as the benchmarks don't take this into account. The main thing is to ensure the numbers stay low enough that sorting isn't going to be a major cost.