This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D5-nicetohaveaudit ⚠️
PR contains trivial changes to logic that should be properly reviewed.
labels
Nov 4, 2021
const ED = new BN(10000000000);
const ledgers = await api.query.staking.ledger.entries();
let count = 0;
let stale = 0;
for (let [ctrl, ledger] of ledgers) {
const total = ledger.unwrapOrDefault().total;
count += 1;
if (total.toBn().lte(ED)) {
stale += 1;
console.log(`🚨 ${ctrl.args[0].toHuman()} has ledger ${api.createType('Balance', total).toHuman()}.`)
}
}
console.log(`${stale} / ${count} are stale`); unravels that there are |
emostov
reviewed
Nov 10, 2021
emostov
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just a few comments
Co-authored-by: Zeke Mostov <[email protected]>
Co-authored-by: Zeke Mostov <[email protected]>
Co-authored-by: Zeke Mostov <[email protected]>
shawntabrizi
approved these changes
Nov 10, 2021
kianenigma
added
B7-runtimenoteworthy
and removed
B0-silent
Changes should not be mentioned in any release notes
labels
Nov 12, 2021
bot merge |
Waiting for commit status. |
Merge cancelled due to error. Error: Checks failed for 459359e |
bot merge |
hellbill
approved these changes
Dec 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool👍
23 tasks
viniul
added
D1-audited 👍
PR contains changes to fund-managing logic that has been properly reviewed and externally audited
and removed
D5-nicetohaveaudit ⚠️
PR contains trivial changes to logic that should be properly reviewed.
labels
Feb 2, 2022
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* rework reap_stash * Update frame/staking/src/pallet/mod.rs Co-authored-by: Zeke Mostov <[email protected]> * Update frame/staking/src/pallet/mod.rs Co-authored-by: Zeke Mostov <[email protected]> * Update frame/staking/src/pallet/mod.rs Co-authored-by: Zeke Mostov <[email protected]> * Fix Co-authored-by: Shawn Tabrizi <[email protected]> Co-authored-by: Zeke Mostov <[email protected]>
AurevoirXavier
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Aug 4, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* rework reap_stash * Update frame/staking/src/pallet/mod.rs Co-authored-by: Zeke Mostov <[email protected]> * Update frame/staking/src/pallet/mod.rs Co-authored-by: Zeke Mostov <[email protected]> * Update frame/staking/src/pallet/mod.rs Co-authored-by: Zeke Mostov <[email protected]> * Fix Co-authored-by: Shawn Tabrizi <[email protected]> Co-authored-by: Zeke Mostov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
D1-audited 👍
PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes reap-stash to be able to also reap an account that due to any reason have a
ledger.active
less than existential deposit. Also makes the transaction signed, but free in case of successful execution, for better protection.