Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Pallet Preimage #10153

Closed
wants to merge 16 commits into from
Closed

Pallet Preimage #10153

wants to merge 16 commits into from

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Nov 2, 2021 •
edited by gavofyork
Loading

Superseded in #10356.

@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Nov 2, 2021
@shawntabrizi shawntabrizi marked this pull request as ready for review November 2, 2021 17:00
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Nov 2, 2021
xlc
xlc reviewed Nov 2, 2021
View reviewed changes
frame/preimage/src/lib.rs Outdated Show resolved Hide resolved
frame/support/src/traits/misc.rs Outdated Show resolved Hide resolved
@gavofyork gavofyork added B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Nov 23, 2021
@gavofyork
Copy link
Member

Just needs a few tests and I'd be happy to merge.

@gavofyork gavofyork mentioned this pull request Nov 23, 2021
Merged
4 tasks
@shawntabrizi shawntabrizi deleted the shawntabrizi-preimage-pallet branch December 10, 2021 02:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kianenigma kianenigma kianenigma left review comments

@xlc xlc xlc left review comments

@gavofyork gavofyork gavofyork left review comments

@andresilva andresilva Awaiting requested review from andresilva

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shawntabrizi @gavofyork @xlc @kianenigma