This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
More lenient mechanism for identifying stash accounts in purge_keys #10004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
changed the title
bkchr
approved these changes
Oct 11, 2021
gavofyork
added
B7-runtimenoteworthy
C1-low
|
This closes: #8543 ? |
|
Yup guess so. |
|
I looked it over, and looked for implications in the staking pallet and session_historical pallet, and didn't find any. Seems fine. |
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a fallback so a stash account can be provided as well as a controller account to identify a validator for key purging. This is because key purging should be able to happen after the staking controller/stash pair has been removed. Right now that's impossible.