use chunks for scalars

paritytech · Mar 18, 2023 · 67987ae · 67987ae
1 parent 1ddd6b8
commit 67987ae
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 13 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/primitives/arkworks/src/utils.rs b/primitives/arkworks/src/utils.rs
@@ -54,8 +54,11 @@ pub fn msm_g1_generic<Curve: Pairing>(bases: Vec<u8>, scalars: Vec<u8>) -> Vec<u
 		.into_iter()
 		.map(|a| deserialize_argument::<<Curve as Pairing>::G1Affine>(a))
 		.collect();
-	let scalars: Vec<_> =
-		scalars.iter().map(|a| deserialize_argument::<Curve::ScalarField>(a)).collect();
+	let scalars: Vec<_> = scalars
+		.chunks(Curve::ScalarField.serialized_size(Compress::No))
+		.into_iter()
+		.map(|a| deserialize_argument::<Curve::ScalarField>(a))
+		.collect();
 
 	let result =
 		<<Curve as Pairing>::G1 as ark_ec::VariableBaseMSM>::msm(&bases, &scalars).unwrap();
@@ -69,8 +72,11 @@ pub fn msm_g2_generic<Curve: Pairing>(bases: Vec<u8>, scalars: Vec<u8>) -> Vec<u
 		.into_iter()
 		.map(|a| deserialize_argument::<<Curve as Pairing>::G2Affine>(a))
 		.collect();
-	let scalars: Vec<_> =
-		scalars.iter().map(|a| deserialize_argument::<Curve::ScalarField>(a)).collect();
+	let scalars: Vec<_> = scalars
+		.chunks(Curve::ScalarField.serialized_size(Compress::No))
+		.into_iter()
+		.map(|a| deserialize_argument::<Curve::ScalarField>(a))
+		.collect();
 
 	let result =
 		<<Curve as Pairing>::G2 as ark_ec::VariableBaseMSM>::msm(&bases, &scalars).unwrap();