Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show error trace to the user #32

Closed
bkchr opened this issue Nov 21, 2022 · 2 comments · Fixed by #42
Closed

Do not show error trace to the user #32

bkchr opened this issue Nov 21, 2022 · 2 comments · Fixed by #42
Assignees
@parutger

Comments

@bkchr
Copy link
Member

bkchr commented Nov 21, 2022

The bot currently is posting the full error context into a github comment. As an example see here: paritytech/substrate#12723 (comment)

It should only post:

@bkchr ERROR: Error: Contributor did not properly post their account address.

Make sure the pull request description has: "{network} address: {address}".
@parutger parutger self-assigned this Dec 7, 2022
parutger added a commit that referenced this issue Feb 17, 2023
@parutger
Improves error handling and user message
542629b 
Fixes #32
@parutger parutger mentioned this issue Feb 17, 2023
Merged
@bkchr
Copy link
Member Author

bkchr commented Feb 17, 2023

@parutger was the fix for this issue already deployed?

Because I just got it again: paritytech/substrate#12833 (comment)

@parutger
Copy link
Contributor

parutger commented Feb 21, 2023 •
edited
Loading

@bkchr Thanks for the feedback, It wasn't deployed to production yet.
It is deployed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parutger parutger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rutger/fix user error trace paritytech/substrate-tip-bot
2 participants
@bkchr @parutger