-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nik api integration with node #83
Conversation
… nik-api-integration-with-node
… nik-api-integration-with-node
I'm getting this error in the chrome devtools on the history page:
|
|
I can't reproduce this again now 🤔 |
This was happening during some localstorage corruption. If you pull latest and clean localStorage this hopefully will not exist |
Ideally this shouldn't error. Maybe do a sanity check on the contents of localStorage, clear it if it is in the wrong format and log a warning? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the error in the console when the local storage is the wrong format this LGTM 👍 I'm out of touch with react so I can't review properly for best practices and use of react though.
Solves #65