WIP: updated deps #13
Conversation
Cargo.toml
Outdated
| hmac = "0.11.0" | ||
| schnorrkel = "0.9.1" | ||
| zeroize = { version = "1.0.0", default-features = false } | ||
| schnorrkel = "0.10.1" |
There was a problem hiding this comment.
We don't use that in Substrate. So, we first should check this and make sure nothing breaks.
There was a problem hiding this comment.
Its used with salt.zeroize(); in fn seed_from_entropyto try and zero the password after. (that is used in a couple of places in substrate)
There was a problem hiding this comment.
If I commit the above suggestion, then the crate won't compile because zeroize is referenced:
Line 58 in c56994c
Maybe I misunderstood your initial comment.
There was a problem hiding this comment.
I meant that we don't use schnorrkel 0.10.1 in Substrate while that is already released since quite some time. Before we merge this, we should ensure that we can bump schnorrkel in Substrate as well and nothing breaks.
There was a problem hiding this comment.
ok finally got a combo of this, substrate and schnorrkle that can play nicely together (I think). Let's see how the substrate pr looks...
related PRs: w3f/schnorrkel#76 , paritytech/substrate#10025
|
if #17 is done, using workspace defined deps from the SDK would likely resolve any need to keep this updated ind. |
|
Done in paritytech/polkadot-sdk#3579. |
could just do sha2 if this is too racey.