Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call payment runtime API directly instead of using custom RPC #1167

Closed
xlc opened this issue Dec 19, 2022 · 0 comments · Fixed by #1169
Closed

Call payment runtime API directly instead of using custom RPC #1167

xlc opened this issue Dec 19, 2022 · 0 comments · Fixed by #1169

Comments

@xlc
Copy link
Contributor

xlc commented Dec 19, 2022

As we are deprecating custom RPC in favour of runtime API, we should avoid transaction payment RPC and use the runtime API directly.

substrate-api-sidecar/src/services/blocks/BlocksService.ts

Line 263 in f80a1ed

} = await api.rpc.payment.queryInfo(

Helps with paritytech/substrate#12633 as there is no more RPC to deal with and support of new runtime API can be done purely on client side without the requirement of updating Substrate node & upgrading all deployments from multiple node providers.

Related: #1165 polkadot-js/api#5384
@xlc xlc changed the title Call payment runtime API directly instead of using custom RPC #5384 Call payment runtime API directly instead of using custom RPC Dec 19, 2022
@xlc xlc mentioned this issue Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid use queryInfo rpc call xlc/substrate-api-sidecar
1 participant
@xlc