expose all HTTP headers #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Aug 9, 2022
| @@ -177,7 +168,7 @@ impl<'a, T: AsyncRead + AsyncWrite + Unpin> Server<'a, T> { | |||
|
|
|||
| let path = request.path.unwrap_or("/"); | |||
|
|
|||
| Ok(ClientRequest { ws_key, protocols, path, headers }) | |||
| Ok(ClientRequest { ws_key, protocols, path, headers: request.headers.to_vec() }) | |||
There was a problem hiding this comment.
so, the headers is parsed from an array which is mutally borrowed so I had to clone it the headers unfortunately.
niklasad1
commented
Aug 9, 2022
| resource: &'a str, | ||
| /// The HTTP headers. | ||
| headers: &'a [Header<'a>], | ||
| headers: Option<&'a HeaderMap>, |
There was a problem hiding this comment.
it doesn't makes sense to use httparse::Header to construct new headers, the type is used for parsed headers and doesn't check whether the header is valid or not.
however, it still possible to enter some conflicting headers such as host, websocket upgrade and similar as these are configured separately.
|
We don't need this anymore as we are using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about how much overhead the allocations in
HeaderMapwill cause.