Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat analogous to
send_binary_mut
in that it allows us to do masking in place, which is one less copy for jsonrpsee.Doing
send_text_mut
would be a closer mirror, but casting&mut str
into&mut [u8]
is unsafe (the originalstr
slice might end up not being valid utf8). Soketto already supports owned buffers internally though, and since jsonrpsee spits out ownedString
s, we can use that to make responses that one memcpy faster.