Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check runtime API versions in the JSON-RPC layer #2995

Merged
merged 3 commits into from
Nov 11, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Nov 10, 2022

Fix #2974
cc #949

This PR modifies runtime_call to support an "API version constraint". This constraint is then verified.
A runtime_call_no_api_check function has also been added as an escape hatch for the state_call JSON-RPC function.

It also updates the payment_info module to account for paritytech/substrate#12633

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────
       -5532 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h06f202055235f70c
       +5532 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hf793864e1b77d572
       +3750 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h8f599a7caa5f7732
       +3591 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hff17af47f3a63b36
       +3579 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h518af10895fe4043
       +3577 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h52e610c581d88910
       -3515 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::heb24cebaea095424
       -3465 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hf18000bd83f241da
       -3362 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h49484abf4c136d6f
       -3339 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h30e19aae4bc50717
       +1623 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h5ff8d35549287838
       -1557 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h73178bee09afb138
       +1445 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hb38ad4bbf428ba24
       -1393 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h52ca3bb37d161ca9
       +1278 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h8f7f971a69a5a08f
       -1231 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h5f9727d487f4d207
       +1231 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::he8ad37f119173b45
       -1225 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h6fb79f5433fd9f4e
       +1012 ┊ smoldot::util::nom_scale_compact_u64::he22cdf48c75bb16b
        +751 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h05376db19a7b9f14
       +3930 ┊ ... and 73 more.
      +10253 ┊ Σ [93 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Nov 11, 2022
@mergify mergify bot merged commit a1c9198 into paritytech:main Nov 11, 2022
@tomaka tomaka deleted the fix-2974 branch November 11, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

payment_queryFeeInfo return value changed
1 participant