Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the database content by restoring chain information from the database #2909

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Oct 20, 2022

Close #1752

This PR removes a lot of fields from the database, as the values of these fields is now computed from the runtime of the finalized block when the client initialized.

While this PR is fully ready, I'm opening it as a draft. Unfortunately, the runtime functions used by the chain information builder weren't always available, and so the loading might fail. This needs to be first figured out.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

@tomaka
Copy link
Contributor Author

tomaka commented Oct 25, 2022

Blocked on #2930

@tomaka tomaka added the blocked Can't work on this issue because it is blocked on something out of our control label Oct 25, 2022
@tomaka
Copy link
Contributor Author

tomaka commented Oct 28, 2022

Since #2930 is not doable, this is instead blocked on #165.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Can't work on this issue because it is blocked on something out of our control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full node should load consensus data from chain storage instead of storing it in database
1 participant