Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version field from struct returned by rpc_methods #2756

Merged
merged 4 commits into from
Sep 23, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Sep 15, 2022

Mimics the change done here: paritytech/substrate#12261

Let's merge this PR only if paritytech/substrate#12261 is approved and merged.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
        -318 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h3ee3b8bb3a29c778
        +314 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h79e45a3d6b68e607
        -257 ┊ <smoldot::json_rpc::methods::RpcMethods as serde::ser::Serialize>::serialize::_::<impl serde::ser::Serialize for <smoldot::json_rpc::methods::RpcMethods as serde::ser::Serialize>::serialize::SerdeRpcMethods>::serialize::hdff94f68de5b8826
        +233 ┊ <smoldot::json_rpc::methods::RpcMethods as serde::ser::Serialize>::serialize::_::<impl serde::ser::Serialize for <smoldot::json_rpc::methods::RpcMethods as serde::ser::Serialize>::serialize::SerdeRpcMethods>::serialize::h11e3c7c7f4a5459e
         -84 ┊ <smoldot::json_rpc::methods::RpcMethods as serde::ser::Serialize>::serialize::h735630db00d52a9e
         +71 ┊ <smoldot::json_rpc::methods::RpcMethods as serde::ser::Serialize>::serialize::h48184d7a3755726a
         -38 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light::json_rpc_service::getters::<impl smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>>::rpc_methods::{{closure}}>>::h9962a96bcad90d41
         +38 ┊ core::ptr::drop_in_place<core::future::from_generator::GenFuture<smoldot_light::json_rpc_service::getters::<impl smoldot_light::json_rpc_service::Background<smoldot_light_wasm::platform::Platform>>::rpc_methods::{{closure}}>>::hc9d2bdee2f806812
          -3 ┊ smoldot::json_rpc::methods::Response::to_json_response::h02347c389273d279
         -44 ┊ Σ [9 Total Rows]

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Sep 23, 2022
@tomaka tomaka removed the automerge Automatically merge pull request as soon as possible label Sep 23, 2022
@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Sep 23, 2022
@mergify mergify bot merged commit 3b8bfb4 into paritytech:main Sep 23, 2022
@tomaka tomaka deleted the rpc-methods-version branch September 23, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants