Retry runtime calls if the proof is invalid #2195
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(not finished, opening as a draft to pick it up later)
We have so-called "call proofs": we ask a node to execute a runtime function and build up a Merkle proof of all the storage values that are accessed during this call.
The proof is then sent back, and the executes the runtime function locally, using the proof in order to "replay" the storage accesses.
What the code currently doesn't handle is the situation where the peer has sent us an incomplete proof, where some storage values are missing. If that happens, we just fail the call altogether, while in reality we should consider that the peer is malicious and retry the request with a different peer.