Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport change to code_substitutes #1844

Closed
tomaka opened this issue Jan 6, 2022 · 3 comments · Fixed by #2127
Closed

Backport change to code_substitutes #1844

tomaka opened this issue Jan 6, 2022 · 3 comments · Fixed by #2127

Comments

@tomaka
Copy link
Contributor

tomaka commented Jan 6, 2022

paritytech/substrate#10600
This was referenced Jan 11, 2022
Merged
Merged
@tomaka
Copy link
Contributor Author

tomaka commented Jan 31, 2022 •
edited
Loading

Remains to do:

  • Update chain specs.
  • Remove the backwards compatibility hack.

Because the code substitutes aren't in use by smoldot yet (they should), there is nothing more to do in this issue.

@melekes
Copy link
Contributor

melekes commented Mar 7, 2022

can I do this?

@tomaka
Copy link
Contributor Author

tomaka commented Mar 7, 2022

Yes!

melekes added a commit that referenced this issue Mar 8, 2022
@melekes
src/chain_spec: remove code_substitutes hack
9b0caaa 
and amend the field's docs
Closes #1844
@melekes melekes mentioned this issue Mar 8, 2022
Merged
@mergify mergify bot closed this as completed in #2127 Mar 8, 2022
mergify bot added a commit that referenced this issue Mar 8, 2022
@melekes @mergify
src/chain_spec: remove code_substitutes hack (#2127)
703ec24 
* src/chain_spec: remove code_substitutes hack

and amend the field's docs
Closes #1844

* add codeSubstitutes to example.json and polkadot.json

assert codeSubstitutes field is being parsed correctly

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src/chain_spec: remove code_substitutes hack paritytech/smoldot
2 participants
@melekes @tomaka