This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Install wasm target into nightly toolchain #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Projects with substrate version less than 0.9.42 need wasm target installed into nightly toolchain.
rcny
approved these changes
May 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects with substrate version less than 0.9.42 need wasm target installed into nightly toolchain. Though a project itself can be built on stable, the wasm-builder searches for the latest nightly toolchain with wasm target programmatically. It was fixed here and released only in 0.9.42, so all versions before that need to have a nightly (even not active) toolchain with wasm target installed.
We are currently facing an issue with benchmarking Trappist via command bot. Trappist is built on v0.9.37. There are other projects suffering from this as well.