Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release v0.9.0 #33

Merged
merged 2 commits into from
Nov 13, 2024
Merged

chore: release v0.9.0 #33

merged 2 commits into from
Nov 13, 2024

Conversation

niklasad1
Copy link
Member

No description provided.

@niklasad1 niklasad1 requested a review from a team November 11, 2024 13:25
lexnv
lexnv approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe we need a Cargo.lock or release of dependencies? I think some crate versions are not properly selected yet

@niklasad1
Copy link
Member Author

nit: Maybe we need a Cargo.lock or release of dependencies? I think some crate versions are not properly selected yet

So, we could maybe refactor

Anyway, I don't think these needs to be breaking releases so should be good to go I think.
Or what crate versions did you have in mind?

jsdw
jsdw approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I wonder what you mean @lexnv, ie we do want to avoid there being duplicate scale_* dependencies etc ofc :)

@niklasad1 niklasad1 merged commit 5caa282 into main Nov 13, 2024
9 checks passed
@niklasad1 niklasad1 deleted the chore-release-0.9.0 branch November 13, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasad1 @jsdw @lexnv