Improve error handling + consistency when no_std #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2023
tadeohepperle
approved these changes
Jul 28, 2023
lexnv
reviewed
Jul 31, 2023
| WrongLength { | ||
| /// Length we have | ||
| actual_len: usize, | ||
| /// Length expected for type. | ||
| expected_len: usize, | ||
| }, | ||
| /// We cannot encode the number given into the target type; it's out of range. | ||
| #[display(fmt = "Number {value} is out of range for target type {expected}")] |
There was a problem hiding this comment.
minor nit: we could keep consistency with commit, although I like it how it is right now
There was a problem hiding this comment.
Actually, I undid the other ones because I realised they weren't really necessary!
lexnv
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I standardised no_std errors to be
Display + Debug, which is closer to the "real"std::error::Errortrait (and is whatserdedoes too forno_std), exposed a couple of helpers to make constructing them from strings simpler (scale-valueandsubxtuse these) and made use ofderive_moresince it's used inscale-valueanyway, and is rather helpful.Also bumped the version ready for a new release once this merges.
Part of a series:
Changes tested against Subxt; I'll update that next.