More graceful handling of lacking merge/close permissions

[rzadp]

Instead of completely failing when lacking the merge/close permissions, it will print an appropriate comment in the PR.

[mordamax]

you mean "close PR" ?
as it's not merging

[rzadp]

Thanks, changed to close.

[mordamax]

else?

[rzadp]

The previous if has a return, so the else is not needed.
However I added it anyways.

[mordamax]

Does it close the Pull request? Is it desired to close, or might they have additional work and another round of vote?

[rzadp]

Yes, we close it because in this situation it's not just a missing approval, in this situation we have an explicit RFC_REJECT referendum which passed. I pushed a commit trying to make it a little more explicit.

[rzadp]

Here is some more explanation:

rfc-action/src/find-referendum-state.ts

Lines 9 to 15 in 708c628

	/**
	* @returns Find the state of a referendum concerning this RFC.
	* The returned RFC referendum state can be one of:
	* - approved (and executed) - meaning the referendum approving this RFC has passed and has been executed,
	* - rejected (and executed) - meaning the referendum rejecting this RFC has passed and has been executed,
	* - null, meaning that the referendum in a proper state with a proper remark has not been found. It's possible there is a referendum approving or rejecting this RFC but has not passed and not been executed yet.
	*/

[Bullrich]

I would recommend to link to the logs.

You can do something along this lines:

const logs = `${context.serverUrl}/${repo.owner}/${repo.repo}/actions/runs/${context.runId}`;

await comment(`There was a problem. Check the [logs here](${logs})`);

It makes it easier to debug.

[rzadp]

I would recommend to link to the logs.

You can do something along this lines:

const logs = `${context.serverUrl}/${repo.owner}/${repo.repo}/actions/runs/${context.runId}`;

await comment(`There was a problem. Check the [logs here](${logs})`);

It makes it easier to debug.

Great suggestion, already auto-merged so will do in #21