Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct environment in release action #39

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Use correct environment in release action #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ jobs:
push_to_registry:
name: Push Docker image to Docker Hub
runs-on: ubuntu-latest
environment: releases
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure - will it fallback to non-env secrets if they not found in environment? like DOCKER_USERNAME

can't CRATESIO_TOKEN be non-env?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure - will it fallback to non-env secrets if they not found in environment? like DOCKER_USERNAME

it should

can't CRATESIO_TOKEN be non-env?

This was requested by security, and it's totally justified IMO. "Releases" environment is limited to v* tags only, same as this workflow.

steps:
- name: Check out the repo
uses: actions/checkout@v4
Expand Down Expand Up @@ -36,6 +37,7 @@ jobs:
publish_crates:
name: Publish crates to crates.io
runs-on: ubuntu-latest
environment: releases
container:
image: docker.io/paritytech/ci-unified:bullseye-1.79.0-2024-06-10-v202408151233
steps:
Expand Down
Loading