Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print errors by default (log-level = info) #30

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Feb 26, 2024

When checking prdoc files, I am interested in the actual errors. They are already printed,
but default log level is none. IMO it should be info.

Example output after change:

[2024-02-26T08:42:53Z INFO  prdoclib::commands::check] Checking directory prdoc
[2024-02-26T08:42:53Z INFO  prdoclib::commands::check] Using schema: /Users/sebastian/work/repos/polkadot-sdk/prdoc/schema_user.json
[2024-02-26T08:42:53Z INFO  prdoclib::commands::check] errors: [
        Properties {
            path: "",
            detail: "Additional property 'tle' is not allowed",
        },
        Required {
            path: "/title",
        },
    ]
[2024-02-26T08:42:53Z INFO  prdoclib::commands::check] missing: []
[2024-02-26T08:42:53Z ERROR prdoclib::commands::check] NumberNotFound(3002)
PR #3243 -> ERR
PR #3002 -> ERR
Checked 2 files.

@skunert skunert added the enhancement New feature or request label Feb 26, 2024
@mordamax mordamax requested a review from a team February 27, 2024 17:56
@mutantcornholio mutantcornholio merged commit 0b0d363 into master Feb 27, 2024
3 checks passed
@mutantcornholio mutantcornholio deleted the skunert/prdoc-log branch February 27, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants